[AIROCMLIR-446] Lower migraphx.relu into linalg.max ins (0, x)#2231
Open
Mr-Anyone wants to merge 4 commits intopr-template-migraphx-to-linalg-3from
Open
[AIROCMLIR-446] Lower migraphx.relu into linalg.max ins (0, x)#2231Mr-Anyone wants to merge 4 commits intopr-template-migraphx-to-linalg-3from
migraphx.relu into linalg.max ins (0, x)#2231Mr-Anyone wants to merge 4 commits intopr-template-migraphx-to-linalg-3from
Conversation
Mr-Anyone
requested review from
dhernandez0,
justinrosner,
pabloantoniom and
umangyadav
Mr-Anyone
force-pushed
the
pr-template-migraphx-to-linalg-4
branch
from
6873508 to
c03e94c
Compare
Mr-Anyone
force-pushed
the
pr-template-migraphx-to-linalg-3
branch
from
69d9574 to
a793a6a
Compare
Mr-Anyone
force-pushed
the
pr-template-migraphx-to-linalg-4
branch
from
c03e94c to
c51ed1b
Compare
umangyadav
reviewed
Feb 9, 2026
| @@ -0,0 +1,14 @@ | |||
| // RUN: rocmlir-opt -split-input-file --migraphx-to-linalg -verify-diagnostics %s | FileCheck %s | |||
Member
There was a problem hiding this comment.
Relu is also pointwise. Can you keep test for Relu in same file as elementwise ?
Mr-Anyone
force-pushed
the
pr-template-migraphx-to-linalg-3
branch
2 times, most recently
from
727a8fa to
590daf6
Compare
Mr-Anyone
force-pushed
the
pr-template-migraphx-to-linalg-4
branch
3 times, most recently
from
d9857f0 to
880e493
Compare
Mr-Anyone
force-pushed
the
pr-template-migraphx-to-linalg-3
branch
from
590daf6 to
ba9cb63
Compare
Mr-Anyone
force-pushed
the
pr-template-migraphx-to-linalg-4
branch
from
880e493 to
51c5c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Being able to lower
migraphx.reluinto linalg.Technical Details
This change lowers migraphx.relu by expressing it as a linalg operation that computes the elementwise maximum between the input tensor and zero, using standard linalg primitiv
Test Plan
Added a new lit test to verify correct lowering of migraphx.relu into linalg.
Test Result
All added and existing lit tests pass.
Submission Checklist