Ignore unnecessary tuning output fields#1026
Merged
mirza-halilcevic merged 1 commit intopf-tuna-rocmlir-3from Feb 6, 2026
Merged
Ignore unnecessary tuning output fields#1026mirza-halilcevic merged 1 commit intopf-tuna-rocmlir-3from
mirza-halilcevic merged 1 commit intopf-tuna-rocmlir-3from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the rocMLIR worker to handle additional metadata fields that were added to the tuning output format. The change ensures MITuna continues to function correctly by extracting only the required fields and ignoring any extra metadata fields.
Changes:
- Modified tuple unpacking to slice the first 6 elements from the parse result
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dorde-antic
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There were changes to the tuning output with additional fields added in ROCm/rocMLIR#2208. MITuna doesn't care about the new fields since they are metadata.
Technical Details
Ignore any extra fields after the ones we need.
Test Plan
Test Result
Submission Checklist