refactor(run.lua): insert_commented works with piped expressions#504
Merged
refactor(run.lua): insert_commented works with piped expressions#504
Conversation
Enhance the `insert_commented` function to handle multi-line code blocks by stripping comments and collapsing them into a single line. Improve cursor movement to the end of the chain for better user experience. refactor(send.lua): modularize pipe chain extraction logic Introduce `get_pipe_node` and `get_pipe_chain` functions to modularize the logic for extracting pipe chain nodes and code. This improves readability and maintainability. Add support for handling comments and cursor positioning within piped expressions. Thank you to @guilhermegarcia for the initial implementation and the general idea. Co-authored-by: Guilherme D. Garcia <guilherme.garcia@lli.ulaval.ca>
PMassicotte
changed the title
Member
|
Thank you, @guilhermegarcia and @PMassicotte! In a quick test, it works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the
insert_commentedfunction to handle multi-line code blocks by stripping comments and collapsing them into a single line. Improve cursor movement to the end of the chain for better user experience.refactor(send.lua): modularize pipe chain extraction logic
Introduce
get_pipe_nodeandget_pipe_chainfunctions to modularize the logic for extracting pipe chain nodes and code. This improves readability and maintainability. Add support for handling comments and cursor positioning within piped expressions.Thank you to @guilhermegarcia for the initial implementation and the general idea.