Draft
Conversation
Member
Author
|
Useful links for future self:
|
martinRenou
force-pushed
the
colormaps
branch
4 times, most recently
from
b84ab29 to
a54187a
Compare
martinRenou
force-pushed
the
colormaps
branch
from
a54187a to
3e166ce
Compare
martinRenou
commented
Jan 21, 2021
Member
Author
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
We need to check how paraview does the interpolation
| break; | ||
| case ColorSpace.HSV: | ||
| throw 'ColorSpace.HSV not supported'; | ||
| break; |
Member
Author
There was a problem hiding this comment.
Need to review this part of the code
|
|
||
| // Add support for log scales scaleSequentialLog | ||
| const divergingColorScale = d3Scale.scaleSequential((value: number) => { | ||
| for (let i = 0; i < controlPoints.length - 1; i++) { |
Member
Author
There was a problem hiding this comment.
The complexity of this code might be important
Member
Author
|
Needs a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc. @ejtovar
Working on supporting Paraview colormaps. I will also add support for importing custom colormaps the same way Paraview does it.