Clean up badge links in README#1881
Closed
adnan-bhaldar wants to merge 1 commit intoQL-Win:masterfrom
Closed
Conversation
Removed unnecessary anchor tags from badge section.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSimplifies the README badge section by removing redundant anchor tags around the badge images and normalizes the file ending, leaving badges as plain images without hyperlink behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- By removing the anchor tags, the badges are no longer clickable; if the intent was only to simplify markup, consider keeping links on at least the most-used badges (e.g., releases, actions, license) for usability.
- There is now an extra leading indentation on the first
<img>line and a trailing space at the end of that line; consider normalizing indentation and trimming trailing whitespace for consistency with the rest of the README.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- By removing the anchor tags, the badges are no longer clickable; if the intent was only to simplify markup, consider keeping links on at least the most-used badges (e.g., releases, actions, license) for usability.
- There is now an extra leading indentation on the first `<img>` line and a trailing space at the end of that line; consider normalizing indentation and trimming trailing whitespace for consistency with the rest of the README.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
I’m currently considering keeping those links, as there’s no special reason to remove them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary anchor tags from badge section.
PR Checklist
Brief Description of Changes
Please briefly describe the main changes in this PR:
Related Issue (if any)
Please provide related issue numbers:
Additional Notes
Add any extra notes here:
Summary by Sourcery
Documentation: