This repository was archived by the owner on May 3, 2024. It is now read-only.
Add full pwsh7 compatibility #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powershell 7 does not support -encoding byte on add/get content. Instead it uses the 'asbytestream' switch. This uses parameter splatting to convert all references to add- and get-content to be compatible regardless of powershell version.
Author
|
@microsoft-github-policy-service agree |
breakwaterlabs
commented
Aug 21, 2023
| } elseif ($PSVersionTable.PSVersion.Major -gt "5") | ||
| { | ||
| $byteParam = @{AsByteStream = $True} | ||
| } |
Author
There was a problem hiding this comment.
Used the same version detection logic merged in earlier commits, but instead of using that to call a function we just define the correct parameter as a hashtable.
breakwaterlabs
commented
Aug 21, 2023
| { | ||
| [byte[]] $policyContentInBytes= get-content $path -AsByteStream -Raw | ||
| } | ||
| [byte[]] $policyContentInBytes = Get-Content $Path -Raw @byteParam |
Author
There was a problem hiding this comment.
Now we can remove the logic from mid-function and instead simply splat the hashtable
breakwaterlabs
commented
Aug 21, 2023
| [System.BitConverter]::GetBytes($script:REGFILE_SIGNATURE) | Add-Content -Path $Path -Encoding Byte | ||
| [System.BitConverter]::GetBytes($script:REGISTRY_FILE_VERSION) | Add-Content -Path $Path -Encoding Byte | ||
| [System.BitConverter]::GetBytes($script:REGFILE_SIGNATURE) | Add-Content -Path $Path @byteParam | ||
| [System.BitConverter]::GetBytes($script:REGISTRY_FILE_VERSION) | Add-Content -Path $Path @byteParam |
Author
There was a problem hiding this comment.
This allows us to easily make all calls to add/get-content compatible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powershell 7 does not support -encoding byte on add/get content. Instead it uses the 'asbytestream' switch.
This uses parameter splatting to convert all references to add- and get-content to be compatible regardless of powershell version.
PR Summary
PR Context