feat. added batched process in PermissionRegistry to avoid lagging #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… batch size of 256 to avoid lagging .
Contributor
Author
|
Attachment: |
svenar-nl
approved these changes
Jun 5, 2025
Member
svenar-nl
left a comment
svenar-nl
left a comment
There was a problem hiding this comment.
Looks good :). The pom.xml changes are indeed necessary to successfully build PowerRanks due to a change in a remote repository, great catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I found that garbage collection is often stuck after adding this plugin to my server. After I performed heap dump, I found that a ConcurrentLinkedQueue with many nodes occupied most of the resources and could not be released.
After troubleshooting, I found the PermissionRegistry of PowerRanks. This queue is polled only once per tick during running. In some cases where permission requests are frequent (for example, in my game server), the queue will block, and then the game will get stuck.
This PR aims to eliminate this kind of stuck problem. By modifying the code and adding batch processing logic, the current code will poll 256 nodes at a time. After testing, the problem of stuck problem has been completely solved.
In addition, as for the problem of accidentally modifying pom.xml, the main reason is that if I don't modify it to this address, I can't build it. If it's unnecessary, you can roll back the modification.