feat: group controls by type #46475
Open
feat: group controls by type #46475
+263
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Member
Author
|
@fasyy612 wondered what you think of this change.... no strong opinion from me but felt like a nicer functional grouping |
Contributor
|
Size Change: +321 B (0%) Total Size: 86.7 MB ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the session recording player controls to improve logical grouping. Navigation controls are moved to the left side, while action controls remain on the right.
Changes:
- Moved
SkipToStartandSkipToNextbuttons from the right control group to the left control group - Left side now contains all navigation controls: skip to start, seek backward, play/pause, seek forward, skip to next, and timestamp
- Right side now exclusively contains action controls: comment, emoji, screenshot, clip, and fullscreen
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pauldambra
force-pushed
the
fix/pd/same-same
branch
3 times, most recently
from
2174cc0 to
9772826
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
pauldambra
force-pushed
the
fix/pd/same-same
branch
2 times, most recently
from
98c140a to
a0eb82a
Compare
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
Contributor
Visual regression: Storybook UI snapshots updatedChanges: 10 snapshots (0 modified, 10 added, 0 deleted) What this means:
Next steps:
|
pauldambra
force-pushed
the
fix/pd/same-same
branch
2 times, most recently
from
ebe9beb to
3a4375c
Compare
Contributor
Visual regression: Storybook UI snapshots updatedChanges: 10 snapshots (10 modified, 0 added, 0 deleted) What this means:
Next steps:
|
frontend/src/scenes/session-recordings/player/controller/PlayerController.stories.tsx
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/player/player-meta/PlayerMetaBar.stories.tsx
Show resolved
Hide resolved
pauldambra
force-pushed
the
fix/pd/same-same
branch
from
825a0d0 to
55e5066
Compare
pauldambra
force-pushed
the
fix/pd/same-same
branch
from
55e5066 to
b698dcf
Compare
Contributor
Visual regression: Storybook UI snapshots updatedChanges: 10 snapshots (10 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the play next and jump to start buttons are much nicer than the old play next button
but made me realise we were almost grouped by type
left for navigation within the replay, right for things you can "do to it"
so lean into that