Skip to content

Conversation

@vdekrijger
Copy link
Contributor

@vdekrijger vdekrijger commented Jan 8, 2026

Problem

@rafaeelaudibert rightfully called out here: PostHog/posthog-php#99 (review) that we have a reference to history.md within the SDK doctor.

As we want to standardise the release process across our SDKs, I've renamed the History.md to CHANGELOG.md for consistency within the posthog-php SDK. As a result, I have also updated the release link to point to: https://github.com/PostHog/posthog-php/releases so that it works regardles if we're using History.md or CHANGELOG.md.

Due to this, we need to update the links here as well.

Changes

How did you test this code?

✅ - CI is passing

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Publish to changelog?

no.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Hey @vdekrijger! 👋\nThis pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@vdekrijger vdekrijger changed the title docs(posthog-php): Update link to changelog after introducing releaser within the PostHog-PHP SDK docs(posthog-php): Update link to changelog after introducing releaser within the posthog-php SDK Jan 8, 2026
Copy link
Member

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're already here, can you fix it for Ruby and Elixir as well? I migrated them to releases a while back but forgot to fix it here.

Also, there's some code in the backend where we fetch all versions from github, can you check that's working as expected? I'm on my phone right now but it should be something along the lines of check_github_sdk_versions or something

@vdekrijger
Copy link
Contributor Author

vdekrijger commented Jan 8, 2026

Fixed Elixir and Ruby in: cf08ea9!

I presume you're talking about this piece of code:

def fetch_php_sdk_data() -> dict[str, Any]:
"""Fetch PHP SDK data from History.md with release dates"""
return fetch_sdk_data_from_releases("PostHog/posthog-php")

I've just removed all the v prefixes in the tags published by the posthog-php releaser, so it should remaing consistent with what we had before (commit: PostHog/posthog-php@e862fa9) 🙌 . But I'll make sure to double check it once I've done a release!

@rafaeelaudibert
Copy link
Member

Fixed Elixir and Ruby in: cf08ea9!

I presume you're talking about this piece of code:

def fetch_php_sdk_data() -> dict[str, Any]:
"""Fetch PHP SDK data from History.md with release dates"""
return fetch_sdk_data_from_releases("PostHog/posthog-php")

I've just removed all the v prefixes in the tags published by the posthog-php releaser, so it should remaing consistent with what we had before (commit: PostHog/posthog-php@e862fa9) 🙌 . But I'll make sure to double check it once I've done a release!

Oh yeah, just make sure we follow the same format now that we did before and you should be good! You can always ask for an admin help to go and fix any tag you release incorrectly.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 8, 2026

Greptile encountered an error while reviewing this PR. Please reach out to support@greptile.com for assistance.

@vdekrijger vdekrijger merged commit 67baf2b into master Jan 8, 2026
126 of 128 checks passed
@vdekrijger vdekrijger deleted the vdekrijger-update-link-to-changelog branch January 8, 2026 18:47
abhischekt pushed a commit that referenced this pull request Jan 9, 2026
tomasfarias pushed a commit that referenced this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants