-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs(posthog-php): Update link to changelog after introducing releaser within the posthog-php SDK
#44560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r within the PostHog-PHP SDK
|
Hey @vdekrijger! 👋\nThis pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
posthog-php SDK
rafaeelaudibert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're already here, can you fix it for Ruby and Elixir as well? I migrated them to releases a while back but forgot to fix it here.
Also, there's some code in the backend where we fetch all versions from github, can you check that's working as expected? I'm on my phone right now but it should be something along the lines of check_github_sdk_versions or something
|
Fixed Elixir and Ruby in: cf08ea9! I presume you're talking about this piece of code: posthog/products/growth/dags/github_sdk_versions.py Lines 265 to 267 in 3c3fac8
I've just removed all the |
Oh yeah, just make sure we follow the same format now that we did before and you should be good! You can always ask for an admin help to go and fix any tag you release incorrectly. |
|
Greptile encountered an error while reviewing this PR. Please reach out to support@greptile.com for assistance. |
…r within the `posthog-php` SDK (#44560)
…r within the `posthog-php` SDK (#44560)
Problem
@rafaeelaudibert rightfully called out here: PostHog/posthog-php#99 (review) that we have a reference to
history.mdwithin the SDK doctor.As we want to standardise the release process across our SDKs, I've renamed the
History.mdtoCHANGELOG.mdfor consistency within theposthog-phpSDK. As a result, I have also updated the release link to point to: https://github.com/PostHog/posthog-php/releases so that it works regardles if we're usingHistory.mdorCHANGELOG.md.Due to this, we need to update the links here as well.
Changes
posthog-phprepository (feat(ci/cd): Add releaser integration posthog-php#99).How did you test this code?
✅ - CI is passing
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
no.