Skip to content

Conversation

@daphnehanse11
Copy link
Collaborator

fixes #6809

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@7051281). Learn more about missing BASE report.
⚠️ Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master     #6810   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         8           
  Lines             ?       111           
  Branches          ?         0           
==========================================
  Hits              ?       111           
  Misses            ?         0           
  Partials          ?         0           
Flag Coverage Δ
unittests 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daphnehanse11 daphnehanse11 force-pushed the daphnehanse11/issue6809 branch from e6115bb to a9c3d5f Compare November 10, 2025 21:34
@daphnehanse11 daphnehanse11 marked this pull request as ready for review November 10, 2025 22:11
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be a structural reform? Can't we add 2026-01-01: 6 to this?

@PavelMakarchuk
Copy link
Collaborator

Why does this need to be a structural reform? Can't we add 2026-01-01: 6 to this?

Agreed, this feels like the simpler solution

@MaxGhenis
Copy link
Contributor

@daphnehanse11 if you agree this can be a parametric reform please close it

@daphnehanse11
Copy link
Collaborator Author

daphnehanse11 commented Dec 10, 2025

@MaxGhenis the reform is a different one now that I think needs the new structural reform. the new proposal requires a 7th bracket, which I thought we need to add structurally.

@MaxGhenis
Copy link
Contributor

Review

Critical Issues

1. 700% FPL reform is not integrated ⚠️

The aca_ptc_700_fpl_cliff.py file is created but:

  • NOT exported from policyengine_us/reforms/aca/__init__.py
  • NOT registered in reforms.py

The 700% reform won't be usable in the web app.

2. Missing tests for 600% FPL reform

Only ptc_700_fpl_cliff.yaml tests exist. No tests for the ptc_600_fpl_cliff reform.

3. Changelog describes wrong reform

Changelog says "ACA PTC 700% FPL cliff reform" but only the 600% reform is actually integrated.

Questions

Which reform is the target policy?

  • 600% FPL cliff (8.5% cap, ends at 600%)
  • 700% FPL cliff (8.5% from 400-600%, phases up to 9.25% at 700%)

If the answer is 700%, then:

  1. Export and register the 700% reform in __init__.py and reforms.py
  2. Either remove the 600% reform or clarify why both are needed
  3. Update the changelog to match

Code Quality

The implementation follows established patterns from aca_ptc_simplified_bracket.py correctly ✅

daphnehanse11 and others added 2 commits December 11, 2025 14:29
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@daphnehanse11 daphnehanse11 force-pushed the daphnehanse11/issue6809 branch from 9fb83ec to 1a7bf3b Compare December 11, 2025 20:04
@PavelMakarchuk PavelMakarchuk merged commit ec3597a into PolicyEngine:master Dec 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create structural reform for house ACA proposal

3 participants