Several fixes

[jbreu]

No description provided.

[jbreu]

Thanks for the reports!

[SpeakerCZ]

In the case of a positive evaluation, the reputation points of the total available quantity are deducted; in the case of a negative evaluation, reputational points are added to the total available quantity.

An example of a positive rating
Reputation points 10 out of a total of 10
I rate a post or user positively with 5 reputation points
The balance is 5 points out of a total of 10

An example of a negative rating
Reputation points 10 out of a total of 10
I evaluate the post or user negatively with 5 reputation points
The balance is 15 points out of a total of 10

But should not 5 points out of 10 ?

[Galixte]

Hi @SpeakerCZ,

i use this extension. I didn’t notice this behavior on my board, you can test it, here: http://www.ezcom-fr.com (select the EN flag if your are not french).

Maybe your settings are not corrects (coherent). If you want, i can share mine in english with screenshots.

[Galixte]

@eeeman1, i suspect an other extension which is related with avatars that’s the cause of your trouble.

[SpeakerCZ]

Hello Galixte,
thank you for being a member of your forum. I'm already registered. We have sent you a private message.

[Galixte]

Ok, i found the same issue like you.

I think the problem is around this part of code: https://github.com/Pico/phpBB-Reputation-System/blob/master/controller/rating_controller.php#L781

The problme is the subtraction https://github.com/Pico/phpBB-Reputation-System/blob/master/controller/rating_controller.php#L758

$voting_power_left = $max_voting_power - $used_power;

Which means:
voting power (A) = maximum allowed voting power (B) - voting power used (C)

BUT it should calculate like this: A = B - C even if =C is negative, for example:

• if B = 20 and C = 5, so:
  A = B - C ==> OK A = 15
• if B = 20 and C = -5, so:
  A = B - (-C) ==> NOT OK A = 25 it should = 15

It takes into account the negative value and adds this with the subtraction thus -- = +.

Any solution @jbreu or @WorkingWarrior ?

[jbreu]

I never used that feature. But reading your comments a quick solution seems to be to use the absolute numbers instead of the actual pos/neg values: A = B - abs(C)

[bobalo2]

Ugh , I'm confused. How do I get this to work with phpbb3.2 ? Can I download the files that were fixed or do I have to change them one by one?

[jbreu]

you may want to download one of the current forks: https://github.com/Pico/phpBB-Reputation-System/network

[Galixte]

For phpBB 3.2.x the last version is here: https://github.com/jbreu/phpBB-Reputation-System/archive/master.zip.

[Fredhoob]

I've been using the 1.1.0-dev pico version on my forum for a while. Could I just replace the files with yours and keep all my previous settings, votes of my members, etc.? Thanks.

[jbreu]

It should work, but a backup of all data is always recommended