Implemented debouncing of interrupts (Github Issue 5)#25
Implemented debouncing of interrupts (Github Issue 5)#25fcrossen wants to merge 2 commits intoPiPHP:masterfrom
Conversation
|
Thanks very much for this feature, it looks well done and very useful - I have briefly read through it and the only comment I would make is that adding a parameter to a function on a public interface is a relatively significant backwards incompatible change. It would probably be less of an issue to maybe add On a related note: I'm looking for someone to maintain this repository and if I can't find someone I'll probably mark the repository as inactive and then provide instructions for users on how to run this feature branch in the README. |
svpernova09
left a comment
There was a problem hiding this comment.
It would probably be less of an issue to maybe add getDebounceTime() and setDebounceTime() to InputPinInterface, as it's unlikely anyone has extended/implemented these.
|
Morning guys, |
Implemented as per the suggestion in that thread.
Updated README.md.
Unit tests need additional coverage to cover debounce and migrating to cover later versions of PHPUnit.