Open
Conversation
Phantomical
approved these changes
Jan 27, 2026
Owner
Phantomical
left a comment
Phantomical
left a comment
There was a problem hiding this comment.
I've been meaning to respond to the other PR for a while but it fell off my radar. I think this should still work on 2015 and 2018 editions since the token gets generated in the 2021 edition and once it is an ident it won't be checked against keywords, but I should probably validate that before I merge this.
Otherwise LGTM with one typo.
DanikVitek
force-pushed
the
raw-lifetimes
branch
from
2f7f832 to
ddb05f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4