feat: add optimization for images in content collection#31
Merged
payam-zahedi merged 7 commits intomainfrom Mar 2, 2025
Merged
feat: add optimization for images in content collection#31payam-zahedi merged 7 commits intomainfrom
payam-zahedi merged 7 commits intomainfrom
Conversation
There was a problem hiding this comment.
PR Overview
This PR implements image path optimizations for member files and updates related code to support locale-specific routing and schema validation.
- Updated image paths in member markdown files for both English and Farsi content
- Enhanced navigation.ts to generate localized URLs using a new locale parameter
- Refactored the config schema for the member collection to dynamically validate the image property
Reviewed Changes
| File | Description |
|---|---|
| src/content/member/en/abolfazlirani.md | Updated image path for the member profile |
| src/content/member/en/payamzahedi95.md | Updated image path for the member profile |
| src/navigation.ts | Updated function signature and URL generation for locale routing |
| src/content/member/fa/abolfazlirani.md | Updated image path for the member profile |
| src/content/config.ts | Refactored schema definition to use dynamic image validation |
| src/content/member/fa/payamzahedi95.md | Updated image path and minor formatting changes in profile markdown |
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/navigation.ts:38
- The comment above still mentions passing only a translation function. Update the comment to reflect the new 'locale' parameter.
export function headerData(locale: string, translation: TranslationValues) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.