fix colorsign bumpmapping#30
Open
medievil1 wants to merge 15 commits intoPatrickvL:hslsl_tss_xbox_extsfrom
Open
fix colorsign bumpmapping#30medievil1 wants to merge 15 commits intoPatrickvL:hslsl_tss_xbox_extsfrom
medievil1 wants to merge 15 commits intoPatrickvL:hslsl_tss_xbox_extsfrom
Conversation
…LORKEYOP, COLORKEYCOLOR (just like ALPHAKILL) in HLSL (both Fixed Function and regular template-based converted shaders). For this, a conversion function was added for L6U5V5 texture format (again based on research medievil did : thanks!). Also added tooling to the conversion functions, to make the code (somewhat) more readable and reduce the chance for errors.
…-to-unsigned mapping
…xemu over the past years
…ource registration function (and only use GetDesc if the caller doesn't have access to those variables). This results in seemingly correct values in g_HostTextureFormats[], but this hits the next hurdle : XboxColorSign isn't always set when it should be, resulting in unintentional signed_to_unsigned mapping for signed host formats like D3DFMT_L6V5U5 (if natively supported). Another area that still needs improvement, is texture component swizzling (we can determine the requirements from kelvin_color_format_map).
hopefully this is a good start, there are still PS issues that can cause some bump effects to not work correctly
PatrickvL
reviewed
Jul 18, 2022
| @@ -1 +1 @@ | |||
| Subproject commit cf178f1fac38426990425cc034f7d4b8c9e1e388 | |||
| Subproject commit c6a35c56016ea2ab2f19115d2ea1e85e0edae155 | |||
Owner
There was a problem hiding this comment.
This should not be part of the pull request
…LORKEYOP, COLORKEYCOLOR (just like ALPHAKILL) in HLSL (both Fixed Function and regular template-based converted shaders). For this, a conversion function was added for L6U5V5 texture format (again based on research medievil did : thanks!). Also added tooling to the conversion functions, to make the code (somewhat) more readable and reduce the chance for errors.
…-to-unsigned mapping
…xemu over the past years
…ource registration function (and only use GetDesc if the caller doesn't have access to those variables). This results in seemingly correct values in g_HostTextureFormats[], but this hits the next hurdle : XboxColorSign isn't always set when it should be, resulting in unintentional signed_to_unsigned mapping for signed host formats like D3DFMT_L6V5U5 (if natively supported). Another area that still needs improvement, is texture component swizzling (we can determine the requirements from kelvin_color_format_map).
PatrickvL
force-pushed
the
hslsl_tss_xbox_exts
branch
from
e883b47 to
60b6e76
Compare
…ess checks inter-INdependent, and apply a fix that helps the BumpMap samples (as discovered by medievil)
PatrickvL
force-pushed
the
hslsl_tss_xbox_exts
branch
from
60b6e76 to
47e007a
Compare
PatrickvL
force-pushed
the
hslsl_tss_xbox_exts
branch
2 times, most recently
from
2db06e2 to
c8d4270
Compare
PatrickvL
force-pushed
the
hslsl_tss_xbox_exts
branch
from
eef50bb to
2a3cd72
Compare
PatrickvL
force-pushed
the
hslsl_tss_xbox_exts
branch
from
2a3cd72 to
cf4e2ca
Compare
RadWolfie
force-pushed
the
hslsl_tss_xbox_exts
branch
from
cf4e2ca to
6351b7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopefully this is a good start, there are still PS issues that can cause some bump effects to not work correctly