Skip to content

Replace hardcoded entity type names with synonym placeholders in English and German translations #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbtronics merged 12 commits into from
Dec 7, 2025
Merged

Replace hardcoded entity type names with synonym placeholders in English and German translations #1128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e161e12
Initial plan
Copilot Dec 4, 2025
59fec61
Initial plan for replacing entity type names with placeholders
Copilot Dec 4, 2025
7fa81ee
Replace entity type names with synonym placeholders in English transl…
Copilot Dec 4, 2025
07cee6a
Add more synonym placeholders for storage location, project, and part…
Copilot Dec 4, 2025
8a59e4f
Update tree navigation labels with synonym placeholders
Copilot Dec 4, 2025
04dec06
Fix remaining entity type placeholders identified in code review
Copilot Dec 4, 2025
df8df14
Fix placeholder syntax: use [Type]/[[Type]] instead of {type}/{{type}…
Copilot Dec 6, 2025
dd1910b
Fix German translation to avoid awkward word concatenation with place…
Copilot Dec 6, 2025
f4b4ed1
Use capitalized placeholders in German translations (nouns are always…
Copilot Dec 6, 2025
fedc817
Fixed length menu for datatable views
jbtronics Dec 6, 2025
e60033a
Capitalize placeholders at the beginning of sentences/titles in Engli…
Copilot Dec 6, 2025
d894e16
Ensure that synonym placeholders get cached on a per locale level
jbtronics Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/EventListener/RegisterSynonymsAsTranslationParametersListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ public function __construct(
$this->translator = $translator;
}

public function getSynonymPlaceholders(): array
public function getSynonymPlaceholders(string $locale): array
{
return $this->cache->get('partdb_synonym_placeholders', function (ItemInterface $item) {
return $this->cache->get('partdb_synonym_placeholders' . '_' . $locale, function (ItemInterface $item) use ($locale) {
$item->tag('synonyms');


Expand All @@ -62,12 +62,12 @@ public function getSynonymPlaceholders(): array
foreach (ElementTypes::cases() as $elementType) {
//Versions with capitalized first letter
$capitalized = ucfirst($elementType->value); //We have only ASCII element type values, so this is sufficient
$placeholders['[' . $capitalized . ']'] = $this->typeNameGenerator->typeLabel($elementType);
$placeholders['[[' . $capitalized . ']]'] = $this->typeNameGenerator->typeLabelPlural($elementType);
$placeholders['[' . $capitalized . ']'] = $this->typeNameGenerator->typeLabel($elementType, $locale);
$placeholders['[[' . $capitalized . ']]'] = $this->typeNameGenerator->typeLabelPlural($elementType, $locale);

//And we have lowercase versions for both
$placeholders['[' . $elementType->value . ']'] = mb_strtolower($this->typeNameGenerator->typeLabel($elementType));
$placeholders['[[' . $elementType->value . ']]'] = mb_strtolower($this->typeNameGenerator->typeLabelPlural($elementType));
$placeholders['[' . $elementType->value . ']'] = mb_strtolower($this->typeNameGenerator->typeLabel($elementType, $locale));
$placeholders['[[' . $elementType->value . ']]'] = mb_strtolower($this->typeNameGenerator->typeLabelPlural($elementType, $locale));
}

return $placeholders;
Expand All @@ -82,7 +82,7 @@ public function __invoke(RequestEvent $event): void
}

//Register all placeholders for synonyms
$placeholders = $this->getSynonymPlaceholders();
$placeholders = $this->getSynonymPlaceholders($event->getRequest()->getLocale());
foreach ($placeholders as $key => $value) {
$this->translator->addGlobalParameter($key, $value);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/EventListener/RegisterSynonymsAsTranslationParametersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function setUp(): void

public function testGetSynonymPlaceholders(): void
{
$placeholders = $this->listener->getSynonymPlaceholders();
$placeholders = $this->listener->getSynonymPlaceholders('en');

$this->assertIsArray($placeholders);
// Curly braces for lowercase versions
Expand Down
11 changes: 10 additions & 1 deletion translations/messages.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13495,5 +13495,14 @@ Vezměte prosím na vědomí, že se nemůžete vydávat za uživatele se zakáz
<target>Uživatelé</target>
</segment>
</unit>
<unit id="MxKRRx_" name="datatable.datatable.lengthMenu">
<notes>
<note priority="1">Do not remove! Used for datatables rendering.</note>
</notes>
<segment state="translated">
<source>datatable.datatable.lengthMenu</source>
<target>_MENU_</target>
</segment>
</unit>
</file>
</xliff>
</xliff>
11 changes: 10 additions & 1 deletion translations/messages.da.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12164,5 +12164,14 @@ Bemærk venligst, at du ikke kan kopiere fra deaktiveret bruger. Hvis du prøver
<target>Brugere</target>
</segment>
</unit>
<unit id="MxKRRx_" name="datatable.datatable.lengthMenu">
<notes>
<note priority="1">Do not remove! Used for datatables rendering.</note>
</notes>
<segment state="translated">
<source>datatable.datatable.lengthMenu</source>
<target>_MENU_</target>
</segment>
</unit>
</file>
</xliff>
</xliff>
Loading
Loading