fix: null check issue fix, silent error fix added #36
Conversation
WalkthroughThe changes update CAPTCHA handling and authentication logic. The CAPTCHA component now directly accesses its ViewChild reference without optional chaining. The login component ensures the CAPTCHA is reset after authentication attempts and clears the result on CAPTCHA resolution. The login service refactors the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LoginComponent
participant CaptchaComponent
participant LoginService
participant Server
User->>CaptchaComponent: Solves CAPTCHA
CaptchaComponent->>LoginComponent: onCaptchaResolved(token)
LoginComponent->>LoginService: authenticateUser(username, pwd, doLogout, captchaToken)
LoginService->>Server: POST /login with credentials and captchaToken
Server-->>LoginService: Response (success or error)
LoginService-->>LoginComponent: Result or error
LoginComponent->>CaptchaComponent: resetCaptcha()
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
src/app/captcha/captcha.component.ts (1)
25-29:⚠️ Potential issueNull-safety regression:
captchaRefmay beundefined
@ViewChildis resolved only after view init and its type is effectivelyElementRef | undefined.
By dropping the optional chaining you re-introduce the possibility of a runtimeTypeError: cannot read property 'nativeElement' of undefinedin rare timing / template-render failures (or unit tests that render the component without the element).-const captchaElement = this.captchaRef.nativeElement; +const captchaElement = this.captchaRef?.nativeElement; +if (!captchaElement) { + console.error('CAPTCHA container element not found'); + return; +}Keeping the defensive check costs nothing and prevents hard-to-diagnose crashes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/app/captcha/captcha.component.ts(1 hunks)src/app/login/login.component.ts(3 hunks)src/app/services/loginService/login.service.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: 5Amogh
PR: PSMRI/Helpline104-UI#35
File: src/app/captcha/captcha.component.ts:43-47
Timestamp: 2025-06-05T06:47:25.642Z
Learning: In the CAPTCHA implementation for PSMRI/Helpline104-UI, token clearing is handled at the parent component (login component) level rather than within the CAPTCHA component's reset method. The CAPTCHA component focuses on widget operations while the parent manages token state.
src/app/login/login.component.ts (1)
Learnt from: 5Amogh
PR: PSMRI/Helpline104-UI#35
File: src/app/captcha/captcha.component.ts:43-47
Timestamp: 2025-06-05T06:47:25.642Z
Learning: In the CAPTCHA implementation for PSMRI/Helpline104-UI, token clearing is handled at the parent component (login component) level rather than within the CAPTCHA component's reset method. The CAPTCHA component focuses on widget operations while the parent manages token state.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build
- GitHub Check: Analyze (javascript)
- GitHub Check: package
🔇 Additional comments (1)
src/app/login/login.component.ts (1)
392-394: Good UX touch – clearing stale login messageClearing
loginResultwhen a new CAPTCHA is solved avoids confusing the user with old error messages. 👍
📋 Description
JIRA ID: 1247
This contains deployment issue fix wrt to type safety compatibility and also fixes a silent error when the api returns 200 status for captcha fail with error status 5002 inside the response.
✅ Type of Change
Summary by CodeRabbit
Bug Fixes
Refactor