Add Security Check to Prevent User Enumeration #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThis update standardizes error handling and logging across authentication and user management methods in the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant IEMRAdminController
participant IEMRAdminUserServiceImpl
Client->>IEMRAdminController: Request (e.g., Authenticate, Password Change)
IEMRAdminController->>IEMRAdminUserServiceImpl: Process Request
IEMRAdminUserServiceImpl-->>IEMRAdminController: Result or Exception
alt Success
IEMRAdminController-->>Client: Success Response
else Error
IEMRAdminController-->>Client: User-friendly Error Message
IEMRAdminController->>IEMRAdminController: Log Warning/Error
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
vanitha1822
requested changes
Jun 27, 2025
| user.setFailedAttempt(user.getFailedAttempt() + 1); | ||
| user.setDeleted(true); | ||
| user = iEMRUserRepositoryCustom.save(user); | ||
| logger.warn("A user account was locked after reaching the limit of {} failed login attempts.", |
Member
There was a problem hiding this comment.
Instead of giving a user account - change to "User Account has been locked...."
| user.setFailedAttempt(user.getFailedAttempt() + 1); | ||
| user.setDeleted(true); | ||
| user = iEMRUserRepositoryCustom.save(user); | ||
| logger.warn("A user account was locked after reaching the limit of {} failed login attempts.", |
|
vanitha1822
approved these changes
Jun 27, 2025
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
JIRA ID: AMM-1249
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
Bug Fixes
Style