Skip to content

Conversation

@volsa
Copy link
Member

@volsa volsa commented Dec 3, 2025

My recommendation for reviewing this PR would be to do it on a commit-basis since they're categorized by LLVM versions. That will also help understand the IR changes introduced with each LLVM version.

(Note for myself: I forgot to update the book documentation, which I should do before we merge this PR)

@volsa volsa force-pushed the vosa/llvm-upgrade branch 2 times, most recently from 893ebc6 to 6044f96 Compare December 11, 2025 09:53
@volsa volsa force-pushed the vosa/llvm-upgrade branch from 6044f96 to 2ea8076 Compare December 11, 2025 10:17
volsa added a commit to PLC-lang/rust-llvm-images that referenced this pull request Dec 11, 2025
Required for PLC-lang/rusty#1557; keeps the LLVM 14 dependency installation intact (for now)
@volsa volsa force-pushed the vosa/llvm-upgrade branch 3 times, most recently from e6d544c to 0864bbe Compare December 16, 2025 13:13
@volsa volsa force-pushed the vosa/llvm-upgrade branch from 0c562ce to 1bd552f Compare December 17, 2025 10:48
@volsa volsa force-pushed the vosa/llvm-upgrade branch from 8d708df to 8d817d6 Compare December 17, 2025 12:39
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 83.75000% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.94%. Comparing base (aca5a52) to head (8d817d6).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/codegen/generators/expression_generator.rs 77.63% 51 Missing ⚠️
src/builtins.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
- Coverage   95.00%   94.94%   -0.06%     
==========================================
  Files         175      174       -1     
  Lines       56038    56246     +208     
==========================================
+ Hits        53239    53403     +164     
- Misses       2799     2843      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@volsa volsa marked this pull request as ready for review December 17, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants