Avoid LDAP TAP tests when not built with LDAP #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `run_misc_tests()` globs the test directories for test modules and
runs them directly, the `if ($ENV{with_ldap} ne 'yes')` bits of the
`Makefile` for `ldap_password_func`, at least, doesn't seem to trigger
properly. So follow the precedent of checking for SSL configuration and
skip LDAP tests when `--with-ldap` (or equivalent) hasn't been
specified.
This presumably wont't come up previously unless TAP tests were enabled
and LDAP was not configured.
theory
force-pushed
the
skip-ldap-tests
branch
from
499a537 to
a76d0cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
run_misc_tests()globs the test directories for test modules and runs them directly, theif ($ENV{with_ldap} ne 'yes')bits of theMakefileforldap_password_func, at least, doesn't seem to trigger properly. So follow the precedent of checking for SSL configuration and skip LDAP tests when--with-ldap(or equivalent) hasn't been specified.This presumably wont't come up previously unless TAP tests were enabled and LDAP was not configured.