Skip to content

Conversation

@sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Dec 17, 2025

  • separate the cross chain stuff into 2 files
  • change checkBalance
  • complete refactoring of CCTPHookWrapper
  • do try-catch on deposit/wihtdraw
  • withdrawal on the remote strategy withdraws the designated amount but then sends the total USDC balance to the Master strategy. To avoid any possible reverts due to insufficient funds withdrawn.
  • there are no more separate messages for confirming a deposit / withdrawal. This is now done via a checkBalance message

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.32%. Comparing base (70166bc) to head (27984d0).
⚠️ Report is 2 commits behind head on shah/cross-chain-strategy-cctpv2.

Files with missing lines Patch % Lines
...strategies/crosschain/CrossChainRemoteStrategy.sol 0.00% 26 Missing ⚠️
...strategies/crosschain/CrossChainMasterStrategy.sol 0.00% 20 Missing ⚠️
...strategies/crosschain/AbstractCCTP4626Strategy.sol 0.00% 19 Missing ⚠️
...racts/strategies/crosschain/CCTPMessageRelayer.sol 0.00% 12 Missing ⚠️
...s/strategies/crosschain/AbstractCCTPIntegrator.sol 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           shah/cross-chain-strategy-cctpv2    #2718      +/-   ##
====================================================================
+ Coverage                             37.28%   37.32%   +0.03%     
====================================================================
  Files                                   134      135       +1     
  Lines                                  6066     6061       -5     
  Branches                               1604     1607       +3     
====================================================================
  Hits                                   2262     2262              
+ Misses                                 3802     3797       -5     
  Partials                                  2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahthepro shahthepro merged commit 7d60614 into shah/cross-chain-strategy-cctpv2 Dec 18, 2025
7 of 17 checks passed
@shahthepro shahthepro deleted the sparrowDom/simplified-ousd-ref branch December 18, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants