-
Notifications
You must be signed in to change notification settings - Fork 95
Upgrade Morpho strategies for MORPHO rewards and deploy new OUSD v2 strategy #2716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2716 +/- ##
==========================================
- Coverage 41.10% 39.07% -2.04%
==========================================
Files 126 126
Lines 5778 5789 +11
Branches 1537 1537
==========================================
- Hits 2375 2262 -113
- Misses 3401 3525 +124
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| contract Generalized4626Strategy is InitializableAbstractStrategy { | ||
| /// @notice The address of the Merkle Distributor contract. | ||
| IDistributor public constant merkleDistributor = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels to me that all these changes should fit into a new contract smth like 4626MerklStrategy.sol. There might be strategies where Generalized4626 would be used (e.g. for Yearn 3 vaults) that won't be using the Merkl rewards distribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I originally did but then realised Generalized4626USDTStrategy would also have to change it's inheritance. Given the addition was small, I decided to just add merkleClaim to Generalized4626Strategy
sparrowDom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left 1 comment inline regarding if a new strategy contract should be made for this added functionality
Added fork tests for claiming Merkl rewards for OUSD v2 Morpho Vault
Changes
claimMerklRewardstoGeneralized4626StrategyclaimMorphoRewardsHardhat taskRewards
Claim and harvest Process
claimMerklRewardson the Morpho strategies which will claim MORPHO tokens to the strategy contract.collectRewardTokens()on the Morpho strategies.Hardhat task to claim the MORPHO rewards
Code Change Checklist
To be completed before internal review begins:
Internal review: