Fix: Correct asyncssh close pattern and test suite errors #51
+66
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Patched `SSHManager.disconnect` to use the correct `conn.close()` and `await conn.wait_closed()` pattern, resolving a `TypeError`. - Added `pytest-mock` to the project dependencies to fix the "mocker not found" test error. - Refactored `test_run_command_always_closes_connection` to use a more accurate mock for `asyncssh` streams, resolving an `AttributeError`. - Fixed `test_apply_update_failure_and_rollback` by creating dummy files and mocking `shutil.copy`, ensuring the test correctly validates the rollback logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSHManager.disconnectto use the correctconn.close()andawait conn.wait_closed()pattern, resolving aTypeError.pytest-mockto the project dependencies to fix the "mocker not found" test error.test_run_command_always_closes_connectionto use a more accurate mock forasyncsshstreams, resolving anAttributeError.test_apply_update_failure_and_rollbackby creating dummy files and mockingshutil.copy, ensuring the test correctly validates the rollback logic.