Refactor StringUtils as core/string headers#676
Merged
Spartan322 merged 1 commit intomasterfrom Dec 5, 2025
Merged
Conversation
schombert
reviewed
Nov 30, 2025
Spartan322
force-pushed
the
refactor/core-string-util
branch
3 times, most recently
from
5f37ff1 to
8083cbc
Compare
BrickPi
reviewed
Dec 4, 2025
Spartan322
force-pushed
the
refactor/core-string-util
branch
4 times, most recently
from
c081b72 to
05cf986
Compare
BrickPi
reviewed
Dec 5, 2025
Rename case-relevant utility functions to reflect ascii-only behavior Prefer use of string_view for Utility.hpp functions Change main.cpp's print_help to use std::string_view for program_name argument
Spartan322
force-pushed
the
refactor/core-string-util
branch
from
05cf986 to
3eff950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename case-relevant utility functions to reflect ascii-only behavior
Prefer use of string_view for Utility.hpp functions
Change main.cpp's print_help to use std::string_view for program_name argument