Skip to content

Conversation

@dbosk
Copy link
Member

@dbosk dbosk commented Jan 21, 2022

Adds a short recap of basic crypto for the tilkry20 course.

@dbosk
Copy link
Member Author

dbosk commented Jan 14, 2026

Status Review (January 2026)

Branch state: 117 commits behind master, last activity March 2020.

What's done:

  • New tilkry-overview/ module with 339 lines:
    • Complete slide infrastructure (slides.tex, preamble.tex, Makefile)
    • Content importing from one-way/, pub-key/, and zkp-smc/ modules
    • 37 lines of original content in contents.tex
  • Minor modifications to one-way/, pub-key/, and zkp-smc/ to support imports
  • Question recipes in Makefile

Assessment:

This PR is ~5 years old and was created for the tilkry20 course iteration. Since then:

  • A course-overview branch was merged (PR Add course overview #87, 2024)
  • The intro/ module has been updated
  • Course structure may have evolved

What's missing:

  • Review whether this content overlaps with or is superseded by current overview materials
  • 117 commits of divergence will likely cause conflicts in one-way/, pub-key/, zkp-smc/

Recommendation:

Evaluate whether this "recap of basic crypto" is:

  1. Already covered by existing intro/overview content → close PR
  2. Still needed as a separate quick review → rebase and update
  3. Useful content to extract and integrate elsewhere → cherry-pick relevant parts

The module structure is sound but may need significant updates to work with current codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants