[in1Utils/out1Plot/runScripts] Function for generating generic debris-flow topography#54
[in1Utils/out1Plot/runScripts] Function for generating generic debris-flow topography#54
Conversation
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
PaulaSp3
left a comment
PaulaSp3
left a comment
There was a problem hiding this comment.
In general, delete all functions that you just copied from avaframe (we co not need the dublicates and can just execute avaframe's functions) as I suggested it for getParabolaParams().
There was a problem hiding this comment.
@fso42: since this file is a dublicate from the corresponding file in avaframe/in3Utils, should we try to avoid dublication? But the only way I know is just using the CfgIni file from avaframe which is not user friendly??
There was a problem hiding this comment.
Is the function plotGeneratedDEM()? If yes, you can delete this file and execute avaframe.out3Plot.outTopo.plotGeneratedDEM()
There was a problem hiding this comment.
Yes, it is plotGeneratedDEM() but I added 'DFTA': 'generic debris-flow topography' in topoNames. Maybe we add this single entry in avaframe.out3Plot.outTopo.plotGeneratedDEM()?
There was a problem hiding this comment.
I would suggest this!
@fso42 what do you think?
|
|
||
| # Local imports | ||
| from debrisframe.in1Utils import generateTopo as gT | ||
| from debrisframe.out1Plot import outTopo as oT |
There was a problem hiding this comment.
| from debrisframe.out1Plot import outTopo as oT | |
| from avaframe.out3Plot import outTopo as oT |
There was a problem hiding this comment.
See comment to debrisframe/out1Plot/outTopo.py above.
2 participants
A function is added to
in1Utils/generateTopo.pyfor generating a generic debris-flow topography.Local subdirectories with dependencies and debrisframe-specific content are also created:
out1Plot/outTopo.pyandrunScripts/runGenerateTopo.py.in1Utils/generateTopoCfg.iniis set to default parameters that correspond to a data-calibrated terrain model.