-
Notifications
You must be signed in to change notification settings - Fork 61
fix: saving workflow with same name as deleted workflow #4165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: saving workflow with same name as deleted workflow #4165
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4165 +/- ##
==========================================
- Coverage 89.05% 89.00% -0.06%
==========================================
Files 425 425
Lines 19677 19687 +10
==========================================
- Hits 17523 17522 -1
- Misses 2154 2165 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@taylordowns2000 this is ready |
taylordowns2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you han!
…as-another-that-is-pending-deletion-is-confusing
Description
This PR introduces a new way to deal with reusing workflow names.
When a name collision happens between workflows
We've updated the error message to inform users that the workflow could be pending deletion
When a workflow is deleted
We add
_del<number>to reduce the chances of a collision.Closes #4156
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)