-
Notifications
You must be signed in to change notification settings - Fork 61
Accept gzip encoded payloads #3938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to have some tests to see what happens when the body is malformed for gunzip. We will want a 4xx error and not a 500. But this implementation looks just fine to me.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3938 +/- ##
==========================================
- Coverage 88.77% 88.74% -0.04%
==========================================
Files 422 422
Lines 18625 18629 +4
==========================================
- Hits 16535 16532 -3
- Misses 2090 2097 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@stuartc just done a big refactor to make it less shite, and generated some tests. Any thoughts? Can I toss it over the fence from here? |
|
@theroinaochieng @stuartc this got left behind. I'm not sure it's still relevant for services, but I also think we should still push it through? |
Description
This PR adds support for gzip-compressed payloads on webhooks.
Closes #3937
Validation steps
See issue
AI Usage
Claude did it all
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy