Skip to content

Conversation

@hunterachieng
Copy link
Contributor

@hunterachieng hunterachieng commented Sep 3, 2025

Short Description

Added label tags to adaptors based on its status: core, community, or legacy

Screenshot 2025-09-04 at 20 33 37 Screenshot 2025-09-04 at 14 16 19

Details

Add any more details that may be relevant to the reviewer. How did you approach
these docs? Are there any parts you struggled with, or that need particularly
careful review?

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
@josephjclark
Copy link
Collaborator

@hunterachieng When I run this locally, I can't see pill styles on the Adaptor Badges section of docs. Like your screenshot above, the badges don't render as pills.

I also haven't got any badges set locally so it's a bit hard to see them in context. Can you include a range of screenshots of each one?

The badge in the Adaptor Badges docs and on each adaptor page should be identical

Also, to be consistent with similar things across the internet, we nee to render the icon and then the badge. Looks like it might be the other way around.

I'm tight for time this week: now that we've sorted some of the plumbing out, you might ask Mtuchi or Marta or Aisha to help you with the basic styling and setup. If this PR is in a state that Marta can review it, then we're in a good place. Then I can come in and have the final word

@josephjclark
Copy link
Collaborator

@hunterachieng loved the demo today! Some feedback based on that:

  1. We should add colour to the badges, a different colour for each
  2. Don't use bullet points in the badge description. Its more like you want to use the badge icon as a bullet. Something like this:
image
  1. I noticed that when hovering over the badge in the adaptor docs, it behaves like a hyperlink - you get an underline on the text and the cursor changes. It should be more like a button: hovering anywhere over the badge should give you a pointer cursor, and maybe the colour lightens slightly to show its interactive.

  2. I can't remember how it looked in the demo, but remember (if you haven't done it already) that the icon should come before the text inside the badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants