test: Improve coverage for Saxon Scales.#154
Open
marinojoey wants to merge 2 commits intoOpenBeta:developfrom
Open
test: Improve coverage for Saxon Scales.#154marinojoey wants to merge 2 commits intoOpenBeta:developfrom
marinojoey wants to merge 2 commits intoOpenBeta:developfrom
Conversation
Coverage reportStatements coverage not met for global: expected <=999999 not covered statements, but got 549
Test suite run success258 tests passing in 17 suites. Report generated by 🧪jest coverage report action from 1b8f6f3 |
d0b6d64 to
82573a3
Compare
musoke
requested changes
Sep 6, 2023
Collaborator
musoke
left a comment
There was a problem hiding this comment.
Thanks for the PR! We already have some tests in src/__tests__/scales/saxon.ts, but they should be in the directory you used. Could you move the existing tests to the location of your current tests and add any new cases to that?
Contributor
@marinojoey can you finish this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to make a test for '7a/7b' but it was erroring that it was not an expected Saxon Grade. I believe this is a problem with the regex in
src/scales/saxon.ts. From some simple testing, this regex matches '7a/7b':1/^((([7-9]|1[0-3])([a-c]))|([1-6])|([7-9]|1[0-3])(([a-c])\/([7-9]|1[0-3])([a-c])))$/i.For now I pushed up tests that pass inside one commit. For the sake of performance, they were specifically written to improve coverage and nothing else (i.e.
__tests__/saxon.tsis not a comprehensive test suite for the Saxon system).The other commit includes a potential solution to the grade regex.