T8 #1662
Merged
T8 #1662
+1,749
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson) from 2.20.1 to 2.21.0. - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-version: 2.21.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson) from 2.20 to 2.21. - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-annotations dependency-version: '2.21' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…-in-genai-implementations Add streaming prompt support for GPT providers (OpenAI, Gemini, Ollama, Anthropic)
…l.jackson.core-jackson-annotations-2.21 Bump com.fasterxml.jackson.core:jackson-annotations from 2.20 to 2.21
…l.jackson.core-jackson-databind-2.21.0 Bump com.fasterxml.jackson.core:jackson-databind from 2.20.1 to 2.21.0
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
…-files Add encrypted oJob file support (.yaml.enc, .json.enc)
…ce tool calling for various models
…to-mermaid Add KaTeX opack hooks alongside Mermaid
Bumps org.snmp4j:snmp4j from 3.9.6 to 3.9.7. --- updated-dependencies: - dependency-name: org.snmp4j:snmp4j dependency-version: 3.9.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.20.0 to 1.21.0. - [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt) - [Commits](apache/commons-codec@rel/commons-codec-1.20.0...rel/commons-codec-1.21.0) --- updated-dependencies: - dependency-name: commons-codec:commons-codec dependency-version: 1.21.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ments from catch handlers
…c-commons-codec-1.21.0 Bump commons-codec:commons-codec from 1.20.0 to 1.21.0
…nmp4j-3.9.7 Bump org.snmp4j:snmp4j from 3.9.6 to 3.9.7
Bumps org.eclipse.jetty.websocket:jetty-websocket-jetty-api from 12.1.5 to 12.1.6. --- updated-dependencies: - dependency-name: org.eclipse.jetty.websocket:jetty-websocket-jetty-api dependency-version: 12.1.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps org.eclipse.jetty:jetty-http from 12.1.5 to 12.1.6. --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-http dependency-version: 12.1.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…jetty.websocket-jetty-websocket-jetty-api-12.1.6 Bump org.eclipse.jetty.websocket:jetty-websocket-jetty-api from 12.1.5 to 12.1.6
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces comprehensive support for encrypted oJob definition files (.yaml.enc, .json.enc) and improves error handling throughout the oJob execution pipeline, while also enhancing JSON-RPC compliance and server-sent event (SSE) streaming capabilities.
Changes:
- Added encrypted oJob definition support with new encryption/decryption methods in Java and JavaScript layers
- Enhanced oJob error handling to allow catch blocks to update arguments and control error propagation
- Improved JSON-RPC compliance with proper error codes, notification handling, and parameter processing
- Optimized SSE streaming with smaller buffers and immediate flushing for text/event-stream content
- Updated multiple dependencies (Jackson, Jetty, commons-codec, snmp4j) to latest versions
Reviewed changes
Copilot reviewed 11 out of 28 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| js/ojob.js | Added helper functions to detect encrypted definitions and block incompatible operations |
| js/owrap.oJob.js | Extended file loading to support encrypted files, refactored catch handler logic for better error control |
| js/owrap.server.js | Improved JSON-RPC compliance with proper error codes and notification handling, enhanced MCP stdio error handling |
| js/owrap.template.js | Added optional KaTeX library loading for math rendering |
| js/owrap.ai.js | Added streaming support and model info methods for multiple AI providers (OpenAI, Gemini, Ollama, Anthropic) |
| src/openaf/AFCmdBase.java | Added dbIP method for byte-based decryption |
| src/openaf/AFBase.java | Added new encryption/decryption methods (encryptBytes, decryptBytes, etc.) |
| src/com/nwu2/httpd/NanoHTTPD.java | Optimized SSE streaming with smaller buffers and immediate flushing |
| tests/autoTestAll.oJob.* | Added comprehensive tests for encrypted YAML and JSON oJob files |
| pom.xml | Updated dependency versions (Jackson, Jetty, commons-codec, snmp4j) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Add error handling for encrypted oJob file parsing failures
4 tasks
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nc jobs Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
[WIP] WIP to address review feedback on PR #1662 for T8 improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for encrypted oJob definition files (such as
.yaml.encand.json.enc) and enhances error handling and security throughout the oJob loading and execution process. It also improves JSON-RPC compliance and robustness in the server module. The most important changes are grouped below:Encrypted oJob Definitions and Security Enhancements:
.yaml.enc,.json.enc), including new helper functions injs/ojob.js(ojob__isEncryptedDefinition,ojob__hasEncryptedIncludes, etc.) to block certain options when encrypted files or includes are detected. [1] [2] [3] [4] [5]OpenWrap.oJob.prototype.__loadFileinjs/owrap.oJob.jsto handle encrypted YAML/JSON files both from disk and URLs, with domain authorization checks and proper decryption. [1] [2] [3]ow.oJobfor detecting encrypted definitions and extracting includes from both resolved and raw files (isEncryptedDefinition,getIncludes,getRawIncludes).Error Handling and Execution Improvements:
catchhandler logic to allow catch blocks to update arguments and control error propagation, improving error handling flexibility inrunJob. [1] [2] [3] [4] [5] [6]Server and JSON-RPC Robustness:
OpenWrap.server.prototype.jsonRPC, returning proper error codes for invalid requests and method not found, and handling notifications correctly.mcpStdioto handle invalid JSON input gracefully, return consistent responses for missing tool names, and avoid sending undefined responses. [1] [2] [3]Miscellaneous: