Skip to content

Adding a mesh reader for Gmsh v4.1 binary format #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wdhawkins wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding a mesh reader for Gmsh v4.1 binary format #926

wdhawkins wants to merge 1 commit into from

Conversation

@wdhawkins
Copy link
Collaborator

@wdhawkins wdhawkins commented Feb 9, 2026

No description provided.

@wdhawkins wdhawkins self-assigned this Feb 9, 2026
@wdhawkins wdhawkins added the enhancement New feature or request label Feb 9, 2026
@wdhawkins wdhawkins force-pushed the gmsh_v4_binary_reader branch from b8f2397 to fa1c3dd Compare February 9, 2026 06:28
ragusa
ragusa reviewed Feb 9, 2026
View reviewed changes
test/python/modules/linear_boltzmann_solvers/transport_steady/transport_2d_gmsh_v4_binary.py
Copy link
Contributor

@ragusa ragusa Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, did you also try to generate the gmsh file as ASCII and see that when read in as ASCII, it gave the exact same answer as the binary. It would be good to have a test that reads in the mesh generated both in ascicc and binary, and check that the difference in the solution is 0.

Copy link
Collaborator Author

@wdhawkins wdhawkins Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, did you also try to generate the gmsh file as ASCII and see that when read in as ASCII, it gave the exact same answer as the binary. It would be good to have a test that reads in the mesh generated both in ascicc and binary, and check that the difference in the solution is 0.

Both the 2D and 3D binary tests are copies of our existing ASCII tests with the meshes saved as binary. They test against the same gold values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ragusa ragusa ragusa approved these changes

@andrsd andrsd Awaiting requested review from andrsd

@quocdang1998 quocdang1998 Awaiting requested review from quocdang1998

Assignees

@wdhawkins wdhawkins

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wdhawkins @ragusa