Add test for installing OpenCAS from RPM package by Ostrokrzew · Pull Request #391 · Open-CAS/open-cas-linux

Ostrokrzew · 2020-04-09T15:06:08Z

Needs https://github.com/Open-CAS/test-framework/pull/166

pep8speaks · 2020-04-09T15:06:13Z

Hello @Ostrokrzew! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-14 13:52:24 UTC

test/functional/tests/install/test_install_rpm.py

test/functional/tests/conftest.py

test/functional/tests/install/test_install_rpm.py

test/functional/api/cas/installer.py

test/functional/tests/install/test_install_rpm.py

test/functional/api/cas/installer.py

test/functional/tests/install/test_install_rpm.py

test/functional/tests/conftest.py

test/functional/api/cas/installer.py

test/functional/api/cas/rpm.py

test/functional/tests/install/test_install_rpm.py

test/functional/tests/conftest.py

test/functional/tests/install/test_install_rpm.py

test/functional/tests/conftest.py

test/functional/api/cas/installer.py

test/functional/tests/conftest.py

test/functional/api/cas/installer.py

test/functional/config/example_dut_config.yml

katlapinka · 2020-06-02T13:36:15Z

retest this please

test/functional/api/cas/rpm.py

test/functional/api/cas/installer.py

test/functional/tests/install/test_install_rpm.py

test/functional/tests/conftest.py

katlapinka · 2020-08-05T10:49:03Z

retest this please

test/functional/api/cas/installer.py

test/functional/tests/conftest.py

test/functional/api/cas/installer.py

Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Remove unused imports from `installer` module. Create class from `installer` with static methods. Wrap `_rsync_opencas`. Add timeout to `_rsync_opencas`. Extract checking if `casadm` works. Remove checking if CAS is installed from `uninstall_opencas` method. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

`RpmInstaller` overwrites few methods to handle RPM functionality. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Add parsing new CLI flag `--rpm-install` to inform framework that user want to install OpenCAS not from sources (default), but from RPM packages. Additionaly user can pass in config file own path to ready-to-install RPM packages. Extend `Opencas` class with field `rpm_dir`. Use new pytest mark in prepare stage. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Deixx · 2020-10-20T12:28:05Z

test/functional/api/cas/installer.py

+        TestRun.LOGGER.info("Check if 'casadm' is properly installed.")
+        output = TestRun.executor.run("casadm -V")
+        if output.exit_code != 0:
+            return False
+        else:
+            TestRun.LOGGER.info(output.stdout)
+            return True


'which casadm' does the job, and we don't need output from casadm here

Deixx · 2020-10-20T12:33:46Z

test/functional/tests/conftest.py

            installer.reinstall_opencas()
-        elif not installer.check_if_installed():
-            installer.rsync_opencas_sources()
+        elif not opencas_installed and not uninstall_cas:


uninstall_cas is always False here

Deixx · 2020-10-20T12:42:14Z

test/functional/tests/conftest.py

+            if opencas_installed:
+                RpmInstaller.uninstall_opencas()
+        elif get_force_param(item) and not TestRun.usr.already_updated:
            installer.reinstall_opencas()


If RPM is installed and we want to reinstall from sources then installer.reinstall_opencas() will try to remove only source-based installation (and fail), and then will try to install from sources although RPM would still be installed.

CAS-Linux-Jenkins · 2022-09-21T12:10:41Z

Can one of the admins verify this patch?

katlapinka · 2024-05-15T10:16:13Z

Remove kedr test and update test for rpm installer

Deixx

test-framework patch lost

Ostrokrzew added the RFC Request For Comments label Apr 9, 2020

Ostrokrzew force-pushed the test_rpm branch from 2b43d78 to 4bcc89d Compare April 14, 2020 08:45

Ostrokrzew changed the title ~~Add test for installing OpenCA from RPM package~~ Add test for installing OpenCAS from RPM package Apr 15, 2020

robertbaldyga requested changes Apr 27, 2020

View reviewed changes

Ostrokrzew force-pushed the test_rpm branch 2 times, most recently from 547e1a2 to 61f062b Compare May 4, 2020 13:35

Ostrokrzew force-pushed the test_rpm branch from 61f062b to 2037a71 Compare May 19, 2020 13:32

Ostrokrzew requested a review from robertbaldyga May 19, 2020 13:36

Ostrokrzew removed the RFC Request For Comments label May 19, 2020

rafalste reviewed May 22, 2020

View reviewed changes

rafalste reviewed May 24, 2020

View reviewed changes

test/functional/tests/install/test_install_rpm.py Outdated Show resolved Hide resolved

mmichal10 reviewed May 26, 2020

View reviewed changes

test/functional/tests/install/test_install_rpm.py Outdated Show resolved Hide resolved

Ostrokrzew force-pushed the test_rpm branch from 2037a71 to 2ddf694 Compare May 26, 2020 11:19

rafalste reviewed May 26, 2020

View reviewed changes

test/functional/tests/install/test_install_rpm.py Outdated Show resolved Hide resolved

test/functional/tests/install/test_install_rpm.py Outdated Show resolved Hide resolved

mmichal10 reviewed May 27, 2020

View reviewed changes

test/functional/tests/conftest.py Outdated Show resolved Hide resolved

Ostrokrzew force-pushed the test_rpm branch 4 times, most recently from db16c41 to 2c94637 Compare May 28, 2020 08:40

Ostrokrzew requested review from mmichal10 and rafalste May 28, 2020 08:41

mmichal10 reviewed May 28, 2020

View reviewed changes

katlapinka requested changes May 28, 2020

View reviewed changes

Deixx requested changes May 28, 2020

View reviewed changes

Ostrokrzew force-pushed the test_rpm branch from 2c94637 to ea9aa02 Compare June 2, 2020 12:22

mmichal10 reviewed Jun 9, 2020

View reviewed changes

test/functional/api/cas/rpm.py Outdated Show resolved Hide resolved

test/functional/api/cas/installer.py Outdated Show resolved Hide resolved

test/functional/tests/install/test_install_rpm.py Outdated Show resolved Hide resolved

Ostrokrzew force-pushed the test_rpm branch 2 times, most recently from b1d5521 to cb7b117 Compare June 10, 2020 12:49

Ostrokrzew force-pushed the test_rpm branch 2 times, most recently from 4440dd5 to 4d6e523 Compare June 25, 2020 09:09

mmichal10 reviewed Jun 30, 2020

View reviewed changes

test/functional/tests/conftest.py Outdated Show resolved Hide resolved

Ostrokrzew force-pushed the test_rpm branch from 4d6e523 to e5d9057 Compare July 13, 2020 15:55

Ostrokrzew mentioned this pull request Jul 30, 2020

Tests for module usage counter after CAS upgrade #478

Closed

Ostrokrzew force-pushed the test_rpm branch 4 times, most recently from c6b3086 to 3b7448a Compare August 7, 2020 08:21

rafalste reviewed Aug 7, 2020

View reviewed changes

Ostrokrzew force-pushed the test_rpm branch 4 times, most recently from 8ed9d93 to c984623 Compare August 12, 2020 09:11

Ostrokrzew force-pushed the test_rpm branch from c984623 to 010de0b Compare August 17, 2020 12:19

Ostrokrzew added 8 commits September 14, 2020 15:51

Add missing import to git module

bf50bad

Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Add new pytest mark - clean_installation

952b477

Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Update example config file

64f399c

Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Create RpmInstaller subclass derived from Installer

724a5c8

`RpmInstaller` overwrites few methods to handle RPM functionality. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Update usage of installer module

c103fbc

Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Add test for installing OpenCAS with RPM

728316e

Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>

Ostrokrzew force-pushed the test_rpm branch from 010de0b to 728316e Compare September 14, 2020 13:52

Deixx requested changes Oct 20, 2020

View reviewed changes

katlapinka added the tests label May 15, 2024

Deixx reviewed Sep 3, 2024

View reviewed changes

Conversation

Ostrokrzew commented Apr 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented Apr 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2020-09-14 13:52:24 UTC

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katlapinka commented Jun 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katlapinka commented Aug 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Deixx Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

Deixx Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

Deixx Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

CAS-Linux-Jenkins commented Sep 21, 2022

Uh oh!

katlapinka commented May 15, 2024

Uh oh!

Deixx left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Ostrokrzew commented Apr 9, 2020 •

edited

Loading

pep8speaks commented Apr 9, 2020 •

edited

Loading