Add rotational field to ocf_core struct#512
Open
Ostrokrzew wants to merge 1 commit intoOpen-CAS:masterfrom
Open
Add rotational field to ocf_core struct#512Ostrokrzew wants to merge 1 commit intoOpen-CAS:masterfrom
Ostrokrzew wants to merge 1 commit intoOpen-CAS:masterfrom
Conversation
Ostrokrzew
changed the title
robertbaldyga
requested changes
Jun 10, 2021
Member
robertbaldyga
left a comment
robertbaldyga
left a comment
There was a problem hiding this comment.
We may also want to skip sorting cache lines for non-rotational drives in the longest sorting function in the entire OCF: ocf_cleaner_sort_flush_containers()
This property is necessary if we don't want to sort cache lines or flush containers when the backend device is not an HDD. Sorting cache lines or flush containers on non-HDDs is a waste of time. Add functions to work with rotational property. Make the cleaner's cache line sorting dependent on the core volume type. If any of the core volumes is HDD, sort cache lines, otherwise do not. Minor typos fix Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
==========================================
- Coverage 64.65% 64.47% -0.19%
==========================================
Files 84 84
Lines 9693 9697 +4
==========================================
- Hits 6267 6252 -15
- Misses 3426 3445 +19
|
|
retest this please |
1 similar comment
|
retest this please |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This property is necessary if we don't want to sort cache lines
when the backend device is not an HDD.
Sorting cache lines on non-HDDs is a waste of time.
Add functions to work with rotational property.
Make the cleaner's cache line sorting dependent on the core volume type.
If any of the core volumes is HDD, sort cache lines, otherwise do not.
Minor typos fix
Signed-off-by: Slawomir Jankowski slawomir.jankowski@intel.com
Fixes #368