Добавил ссылку на список товаров в лого#2
Open
Ruslan-Aleev wants to merge 2 commits intoOkayCMS:masterfrom
Ruslan-Aleev:feature-link-logo
Open
Добавил ссылку на список товаров в лого#2Ruslan-Aleev wants to merge 2 commits intoOkayCMS:masterfrom Ruslan-Aleev:feature-link-logo
Ruslan-Aleev wants to merge 2 commits intoOkayCMS:masterfrom
Ruslan-Aleev:feature-link-logo
Conversation
OkayCMS
reviewed
Feb 22, 2021
| <span class="menu_hamburger"></span> | ||
| </span> | ||
| <a class="logo_box"> | ||
| <a href="index.php?controller=ProductsAdmin" class="logo_box"> |
Owner
There was a problem hiding this comment.
PR принял, но ссылку сделал не на ProductsAdmin, а на контроллер, который для менеджера является первым (главным). По сути контроллер, который в меню стоит первым (мы же пункты меню можем перетягивать для сортировки).
Author
There was a problem hiding this comment.
Вашу логику понял, хотя я привязывался именно к магазину, т.е. удобнее, как мне кажется, именно "товары" открывать, даже если пункт "Товары" и не первый в меню.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Теперь быстрее можно перейти к товарам, меньше кликов, тем более там уже был тег
<a>на лого.