[18.0][ADD] webservice_client_certificate_auth: new module#123
Open
[18.0][ADD] webservice_client_certificate_auth: new module#123
Conversation
vvrossem
force-pushed
the
18.0-add-webservice_client_certificate_auth
branch
from
9a9c865 to
2afcbb3
Compare
The test `test_oauth2_flow_compute_with_ui` iterates over all available `auth_type` values. When a module extends `webservice` with an additional `auth_type` (e.g., `client_certificate`), this test fails because it does not know how to populate the new required fields for that type. This commit restricts the test loop to the authentication types defined in `webservice` module.
ivantodorovich
approved these changes
Feb 4, 2026
gurneyalex
approved these changes
Feb 6, 2026
simahawk
reviewed
Feb 6, 2026
| res = super()._setup_records() | ||
| cls.url = "https://localhost.demo.odoo/" | ||
| # Certificate and private key configuration | ||
| os.environ["SERVER_ENV_CONFIG"] = "\n".join( |
Contributor
There was a problem hiding this comment.
this is the right way to mock env vars https://github.com/OCA/server-env/blob/18.0/server_environment/tests/test_server_environment.py#L59
| self.assertEqual(kwargs["cert"], ("/path/client.cert", "/path/client.key")) | ||
|
|
||
| def test_request_adapter_certificate_only(self): | ||
| with mock.patch("requests.request") as mock_request: |
Contributor
There was a problem hiding this comment.
why not using responses lib? https://github.com/OCA/web-api/blob/18.0/webservice/tests/test_webservice.py#L82
Author
There was a problem hiding this comment.
IIRC, I couldn't retrieve the request's kwargs using responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.