[17.0][IMP]queue_job: only subscribe job creator if indicated via boolean method

[GuillemCForgeFlow]

We add the _subscribe_job_creator method in queue.job which will return True for the cases where we want to subscribe the job creator, False otherwise.

cc @ForgeFlow

[OCA-git-bot]

Hi @guewen,
some modules you are maintaining are being modified, check this out!

[GuillemCForgeFlow]

hi @guewen, any chance you see this a good improvement to the module?
thank you in advance 🙂

[sbidoul]

@GuillemCForgeFlow why is it not sufficient for you to override _subscribe_users_domain ?

[GuillemCForgeFlow]

@GuillemCForgeFlow why is it not sufficient for you to override _subscribe_users_domain ?

@sbidoul, the problem is that the user assigned to the job will always be added anyway: https://github.com/OCA/queue/blob/17.0/queue_job/models/queue_job.py#L359. There may be cases for which we don't want that to happen.
I was also thinking about solving with queue_job_subscribe but thought this would be best. Any ideas on how to solve alternatively are welcomed 🙂

[sbidoul]

the problem is that the user assigned to the job will always be added anyway

Ah yes.

How about this?

def _subscribe_job_creator(self) -> bool
    """Whether the user that created the job should be subscribed to the job, in addition to users determined by `_subscribe_users_domain`"""

[GuillemCForgeFlow]

@sbidoul changes applied, thank you for the feedback 🙂 👍🏿

[GuillemCForgeFlow]

hi @guewen, I'd appreciate it if you have the time to review this small improvement 🙂

[guewen]

Thanks

[GuillemCForgeFlow]

@sbidoul perhaps we can get this merged? I'll take care of the fws 👌🏿

[sbidoul]

/ocabot merge patch

Thanks!

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-865-by-sbidoul-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 1acf4c1. Thanks a lot for contributing to OCA. ❤️