Update Gambit, Gerbil, Glow by fare · Pull Request #114449 · NixOS/nixpkgs

fare · 2021-02-26T09:47:25Z

Update Gambit, Gerbil and Glow with Glow's first release v0.1.0.

Also include some changes in lib that Gerbil support relies on, notably including the POP object system, which by now is rather stable and proven for the purpose of building coherent locally modified sets of packages.

Motivation for this change

Things done

fare · 2021-02-26T09:48:38Z

@7c6f434c

pkgs/development/compilers/gerbil/glow-lang.nix

pkgs/development/compilers/gerbil/gerbil-support.nix

pkgs/development/compilers/gambit/build.nix

7c6f434c · 2021-02-27T09:09:20Z

lib/pop.md

@@ -0,0 +1,433 @@
+# POP: Pure Object Prototypes


(There is a lot of preferring not to die on this hill in my position, and giving up on reasonably quick decision making in Nixpkgs, and giving up on consistency of decision making in Nixpkgs)

My impression is that a lot of extension mechanisms in Nixpkgs are like that because they try to pretend Nix is not a computationally-general-purpose programming language. POP has to come out and pop the bubble of pretence. Which is even a plus in my opinion, but raises the risks.

On the other hand, one extension mechanism that at least recognises its computational power is modules. Which are primarily used for NixOS but now sometimes also inside Nixpkgs. I think it would be nice to include them if you already compare to other extension mechanisms. Additionally, the thing that is popular to dislike about modules is their performance overhead. It's kind of worrying that the question of runtime CPU/RAM consumption is not prominently mentioned…

I admit I never hacked modules, so I cannot comment at the moment.

Note that I created a PR just for POP #116275

fare · 2021-02-27T12:27:51Z

I don't understand the failure in the grahamcofborg-eval job above.

pkgs/development/compilers/gerbil/gerbil-support.nix

pkgs/development/compilers/gerbil/glow-lang.nix

pkgs/development/compilers/gerbil/gerbil-utils.nix

pkgs/development/compilers/gerbil/smug-gerbil.nix

pkgs/top-level/all-packages.nix

fare

PTAL

pkgs/top-level/all-packages.nix

pkgs/development/compilers/gerbil/glow-lang.nix

pkgs/development/compilers/gerbil/smug-gerbil.nix

pkgs/development/compilers/gerbil/gerbil-utils.nix

pkgs/development/compilers/gerbil/gerbil-support.nix

SuperSandro2000

just a small nit. The lib is a bit out of my scope.

pkgs/development/compilers/gerbil/gerbil-ethereum.nix

pkgs/development/compilers/gerbil/glow-lang.nix

fare · 2021-03-09T03:51:43Z

Did all the requested changes, and also merged in the changes from #113405.

PTAL.

siraben · 2021-03-09T04:20:36Z

@fare perhaps the POP-related stuff should be moved to a separate commit and possibly RFC? I'm not sure we need yet another extension mechanism (I'm not familiar with object systems). My preference would be to have this PR do the updates/refactoring with what we have currently and open another PR to add new functions to lib/attrsets.nix and the POP-related stuff.

siraben

After a first pass of pop.md, I like the idea, though I am one of those people who know pure lazy functional programming well and not object systems 😆. I definitely think it warrants further discussion outside of this Nixpkgs PR since if implemented could lead to wider changes and unification in the various heterogeneous extension mechanisms present in Nixpkgs.

lib/pop.md

siraben · 2021-03-09T04:27:42Z

lib/pop.md

Related: shared flake overrides NixOS/nix#4004

siraben · 2021-03-09T04:29:52Z

lib/pop.md

Perhaps explain a bit about the use of existential types here or use forall

siraben · 2021-03-09T04:30:16Z

lib/pop.md

Would be good to have in the RFC!

fare · 2021-03-09T05:31:09Z

I could move the lib stuff to its own PR, but since it's actually of negative value unless used, that would be a catch-22.

Actually, I initially wanted to put pop inside gerbil... but then I found I couldn't extend gerbil with pop if pop was itself in gerbil (or at least it was trickier and uglier). So I moved it to lib, where it belongs eventually. I even started an RFC (82) about having an "official" way to deal with such "experimental" libraries, but it doesn't look like this will ever happen.

7c6f434c · 2021-03-26T15:53:24Z

@SuperSandro2000 should git-version be reported as possible typo when version is also there?

SuperSandro2000 · 2021-03-26T16:37:09Z

Can I insert a comment to disable the attribute-typo warning on line 25 of .../gambit/build.nix ? Other warnings were useful, and fixed.

No, nixpkgs-hammering does not have such a feature right now.

@SuperSandro2000 should git-version be reported as possible typo when version is also there?

probably not.

7c6f434c · 2021-05-08T14:56:34Z

pkgs/development/compilers/gambit/gambit-support.nix

Why removal of arm/x86-64 native targets? Purely for build time reasons?

There are various failures when building "modules" that don't have time to address. Also, while basically working, these backends are missing many features, and they are receiving to love at the moment. Hopefully at some point someone will make them really work, but until then, it's too much hassle for too little upside.

Like the many Jsonnet-style object systems already in Nix, pop combines instance field values and composable prototype information in a same attrset. However pop also implements CLOS-style DAG-based multiple inheritance.

Also use foldr when it makes sense.

Add an indirection between gerbil package parameters and nix packages computed from those parameters, so overlays can easily override the former. Use POP to override packages when the sha256 doesn't match. Run unit-tests of gerbil packages (not integration tests). Fix binaries for gerbil packages. Fix support for gerbil packages including binaries.

7c6f434c · 2021-09-10T13:05:40Z

but then I found I couldn't extend gerbil with pop if pop was itself in gerbil (or at least it was trickier and uglier).

I still don't get it (and we don't have enough shepherd volunteers to reopen global-POP RFC so it makes sense to revisit the least-impact approach).

Let POP live in gerbil directory tree, every version of Gerbil just imports POP and uses it, and then reexports it. If you need POP to extend Gerbil, you just grab it (and it doesn't matter where you grab it from, it is the same import)

I guess you could also have default.nix for Gerbil doing just general composition and defining attributes for various versions, then the top level would just inherit the attributes from it. Then POP can also be taken from gebrilVersions too, if desired.

fare · 2021-09-10T17:56:12Z

As in put it in the passthru of some derivation? Would that cause the derivation to be built?
Or just register it under pkgs.gerbil-support.POP or something?

7c6f434c · 2021-09-10T18:05:17Z

Nix is lazy, so passthru stuff can be used without building the derivation to which it is attached. gerbil-support makes sense, too, of course. I don't have strong opinions here, I just want to avoid global lib changes that are large enough to be controversial.

Release v0.3.1

fare requested review from edolstra, infinisil and nbp as code owners February 26, 2021 09:47

SuperSandro2000 reviewed Feb 26, 2021

View reviewed changes

pkgs/development/compilers/gerbil/glow-lang.nix Show resolved Hide resolved

pkgs/development/compilers/gerbil/gerbil-support.nix Outdated Show resolved Hide resolved

pkgs/development/compilers/gambit/build.nix Outdated Show resolved Hide resolved

7c6f434c reviewed Feb 27, 2021

View reviewed changes

7c6f434c reviewed Feb 28, 2021

View reviewed changes

pkgs/development/compilers/gerbil/gerbil-support.nix Outdated Show resolved Hide resolved

fare force-pushed the alpha branch 2 times, most recently from 3ee10fa to 5b8304d Compare March 4, 2021 18:20

SuperSandro2000 reviewed Mar 7, 2021

View reviewed changes

fare commented Mar 7, 2021

View reviewed changes

fare force-pushed the alpha branch from 5b8304d to 2edc1ea Compare March 7, 2021 17:39

ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 7, 2021

ofborg bot requested review from 7c6f434c and thoughtpolice March 7, 2021 17:49

ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 7, 2021

SuperSandro2000 reviewed Mar 8, 2021

View reviewed changes

pkgs/development/compilers/gerbil/gerbil-ethereum.nix Outdated Show resolved Hide resolved

pkgs/development/compilers/gerbil/glow-lang.nix Outdated Show resolved Hide resolved

pkgs/development/compilers/gerbil/glow-lang.nix Outdated Show resolved Hide resolved

fare force-pushed the alpha branch from 2edc1ea to d5669f1 Compare March 9, 2021 01:47

fare mentioned this pull request Mar 9, 2021

gambit: refactor #113405

Merged

10 tasks

fare force-pushed the alpha branch 2 times, most recently from 8881014 to 3aa2b5f Compare March 9, 2021 02:26

siraben requested changes Mar 9, 2021

View reviewed changes

fare force-pushed the alpha branch 2 times, most recently from 7f8970f to 3aa2b5f Compare March 10, 2021 18:07

fare force-pushed the alpha branch from b46a1c6 to d34a21a Compare May 8, 2021 14:43

7c6f434c reviewed May 8, 2021

View reviewed changes

fare mentioned this pull request May 19, 2021

gambit: Fails to build since deterministically built gcc PR merge #123685

Closed

fare and others added 16 commits September 6, 2021 21:41

lib/attrsets.nix: basic lens access to attrPath

5cd240e

Add yet another pure object prototype system, pop

1caacd9

Like the many Jsonnet-style object systems already in Nix, pop combines instance field values and composable prototype information in a same attrset. However pop also implements CLOS-style DAG-based multiple inheritance.

Yet another pass at documenting pop.nix

e090d32

Also use foldr when it makes sense.

Move pop documentation to its own file

97d330d

pop: implement c3 linearization

5ed4ecf

gambit-unstable: 2020-09-20 -> 2021-06-16

23a2a5d

gerbil-unstable: 2020-11-05 -> 2021-06-08

7fc5b1b

gerbilPackages-unstable.gerbil-utils: 2020-10-18 -> 2020-07-30

1845b05

gerbilPackages-unstable.gerbil-poo: 2020-10-17 -> 2021-05-21

ef6b602

gerbilPackages-unstable.gerbil-crypto: 2020-08-01 -> 2020-05-10

b6dbf95

gerbilPackages-unstable.gerbil-persist: 2020-08-31 -> 2021-03-15

09de2d5

gerbilPackages-unstable.gerbil-ethereum: 2020-10-18 -> 2021-09-07

2ebd590

gerbilPackages-unstable.gerbil-libp2p: 2018-12-27 -> 2021-02-08

d9b57d9

gerbilPackages-unstable.smug-gerbil: 2019-12-24 -> 2020-12-12

48a88b6

gerbilPackages-unstable.ftw: init at 2021-07-30

9bbcf47

fare force-pushed the alpha branch from d34a21a to 614ccd2 Compare September 8, 2021 15:57

ofborg bot requested a review from 7c6f434c September 8, 2021 16:09

glow-lang: init at 2021-09-12

fcd5b99

Release v0.3.1

fare force-pushed the alpha branch from 614ccd2 to fcd5b99 Compare September 12, 2021 21:54

fare closed this Sep 28, 2021

fare deleted the alpha branch September 28, 2021 23:57

Uh oh!

Conversation

fare commented Feb 26, 2021

Motivation for this change

Things done

Uh oh!

fare commented Feb 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fare commented Feb 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fare commented Mar 9, 2021

Uh oh!

siraben commented Mar 9, 2021

Uh oh!

siraben left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siraben Mar 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fare commented Mar 9, 2021

Uh oh!

7c6f434c commented Mar 26, 2021

Uh oh!

SuperSandro2000 commented Mar 26, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

7c6f434c commented Sep 10, 2021

Uh oh!

fare commented Sep 10, 2021

Uh oh!

7c6f434c commented Sep 10, 2021

siraben Mar 9, 2021 •

edited

Loading