Draft
Conversation
- Replaces the abstract protected GroupPropertyNames property with a private dependent property and a static protected method for retrieval. - Adds caching for GroupPropertyNames -Implements getGroupPropertyNamesAcrossTypeHierarchy to aggregate unnamed group property names across the class hierarchy. - Updates fillClass to generate appropriate method overrides for classes with anonymous groups or data.
Refactored the logic to add 'matnwb.mixin.HasUnnamedGroups' as a superclass by combining checks for 'hasAnonGroups' and 'hasAnonData' into a single condition.
The recursive search should invoked for group-based classes and should only be skipped when the current object is a Set or Anon of a tye which inherits the HasUnnamedGroups mixin
Add methods that are present on the Set class, to support accessing Anon values from the HasUnnamedGroups mixin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve upon the changes made in PR #705:
UnnamedGroupMixinas a superclass also when a type has unnamed datasets (Example:VectorDatainDynamicTable)AlignedDynamicTable).How to test the behavior?
Checklist
fix #XXwhereXXis the issue number?