Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #253 +/- ##
=======================================
Coverage 77.83% 77.83%
=======================================
Files 43 43
Lines 803 803
Branches 118 118
=======================================
Hits 625 625
Misses 132 132
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes to the
neurobench/benchmarks/benchmark.pyfile, primarily focusing on enhancing the user interface and improving the benchmark's output presentation. The changes include the addition of therichlibrary for better console output, the removal oftqdmfor progress tracking, and the introduction of a custom progress bar and detailed result display.Key changes include:
User Interface Enhancements:
richlibrary for improved console output and progress tracking. (pyproject.toml,neurobench/benchmarks/benchmark.py) [1] [2]rich.progressto replacetqdmfor more detailed and visually appealing progress updates. (neurobench/benchmarks/benchmark.py)rich.tableandrich.panelto present benchmark results in a structured and readable format. (neurobench/benchmarks/benchmark.py)Code Simplification and Cleanup:
mkdirandtqdm. (neurobench/benchmarks/benchmark.py)to_nirmethod by conditionally importingexport_to_nirbased on thesnntorchversion. (neurobench/benchmarks/benchmark.py)These changes collectively improve the usability and readability of the benchmark output, making it easier for users to track progress and understand results.