refactor(state): split the old state into state reader and state writer structs #3291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infrmtcs
reviewed
Nov 24, 2025
| return fmt.Errorf("get contract nonce: %v", err) | ||
| } | ||
| p.stateDiff.Nonces[*contractAddress] = currentNonce.Add(¤tNonce, feltOne) | ||
| p.stateDiff.Nonces[*contractAddress] = currentNonce.Add(¤tNonce, &felt.One) |
Contributor
There was a problem hiding this comment.
If we're unsure if the felt is eventually modified, we should consider copying it.
MaksymMalicki
force-pushed
the
maksym/state-refactor-2-clean
branch
2 times, most recently
from
7141eaa to
b9b068f
Compare
infrmtcs
reviewed
Dec 2, 2025
Comment on lines
+28
to
+29
| *felt.NewFromUint64[felt.Felt](1): {}, | ||
| *felt.NewFromUint64[felt.Felt](2): {}, |
Contributor
There was a problem hiding this comment.
Suggested change
| *felt.NewFromUint64[felt.Felt](1): {}, | |
| *felt.NewFromUint64[felt.Felt](2): {}, | |
| felt.FromUint64[felt.Felt](1): {}, | |
| felt.FromUint64[felt.Felt](2): {}, |
MaksymMalicki
force-pushed
the
maksym/state-refactor-2-clean
branch
from
b9b068f to
2ad7d63
Compare
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3291 +/- ##
==========================================
+ Coverage 76.14% 76.26% +0.12%
==========================================
Files 349 350 +1
Lines 32937 33117 +180
==========================================
+ Hits 25079 25256 +177
+ Misses 6067 6055 -12
- Partials 1791 1806 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaksymMalicki
force-pushed
the
maksym/state-refactor-2-clean
branch
from
c64de27 to
0d38a9e
Compare
MaksymMalicki
had a problem deploying
to
Development
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following change. The current implementation of the
Stategets split into two structs:StateReader- a structure, which sole purpose is reading the state. It's fed withdb.KeyValueReaderto enforce read-only mode for the state. Eventually we want to feed it only with thedb.Snapshot. It is going to be mainly used during the RPC requests.State- a structure which purpose is reading and writing. TheStateReaderis a part of it. It is used during the synchronisation and execution. Currently it runs using anIndexedBatch, but eventually we want to feed it with anIndexedBatch-like structure, which will contain a write layer anddb.Snapshotfor reads.