Skip to content

Conversation

@MaksymMalicki
Copy link
Contributor

@MaksymMalicki MaksymMalicki commented Oct 18, 2025

This PR should be reviewed after #3187

  • This PR is the first of series of PRs, which introduce components of the pathDB into the rawDB. They are meant to be reviewed and benchmarked separately, to measure the impact on the new state performance.
  • This PR introduces a clean cache layer for the rawDB. The state is meant to read from this layer before the direct PebbleDB hit. We write to clean cache on read miss and also when flushing the nodes to the DB.

Next PR to review: #3192

@MaksymMalicki MaksymMalicki changed the base branch from main to maksym/integrate-common-interface-rawdb October 18, 2025 12:43
@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 37.86982% with 105 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (maksym/integrate-common-interface-rawdb@dc23482). Learn more about missing BASE report.

Files with missing lines Patch % Lines
core/mocks/mock_commonstate_reader.go 0.00% 69 Missing ⚠️
core/state/state.go 54.54% 6 Missing and 9 partials ⚠️
core/trie2/triedb/pathdb/journal.go 16.66% 5 Missing ⚠️
core/trie2/triedb/pathdb/disklayer.go 0.00% 4 Missing ⚠️
core/trie2/triedb/rawdb/database.go 80.00% 1 Missing and 3 partials ⚠️
rpc/v9/storage.go 25.00% 2 Missing and 1 partial ⚠️
core/trie2/triedb/rawdb/cache.go 89.47% 1 Missing and 1 partial ⚠️
rpc/v8/storage.go 33.33% 2 Missing ⚠️
core/trie2/triedb/database.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##             maksym/integrate-common-interface-rawdb    #3188   +/-   ##
==========================================================================
  Coverage                                           ?   75.83%           
==========================================================================
  Files                                              ?      329           
  Lines                                              ?    32655           
  Branches                                           ?        0           
==========================================================================
  Hits                                               ?    24765           
  Misses                                             ?     6119           
  Partials                                           ?     1771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants