A few more improvements to the Makefile#1429
Open
sethk wants to merge 1 commit intoNetflix:masterfrom
Open
Conversation
- Don't require bash for pushd; every line is a separate invocation of the shell, so it's not necessary to clean up - Rename ENABLE_FLOAT to MESON_OPTIONS so I can do make MESON_OPTIONS='-Denable_float=true -Dbuilt_in_models=true' - Prevent clean targets from running in parallel to any other targets. This fixes make -j8 distclean test for example. - Use the direct paths to .venv/bin/meson and ninja as targets for the venv pip installs, rather than $(MESON) and $(NINJA). Some of my environments are unable to build meson or ninja inside the venv, especially since we're not specifying a version. This allows you to do make NINJA=/mingw64/bin/ninja for example. - Use the ninja.build files as targets, as the mtime of the build directory is not a guarantee that the meson setup succeeded. - Upgrade pip using .venv/bin/python -m pip install --upgrade pip instead of via .venv/bin/pip, as this errors out when there is an update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't require bash for pushd; every line is a separate invocation of the shell, so it's not necessary to clean up
Rename ENABLE_FLOAT to MESON_OPTIONS so I can do make MESON_OPTIONS='-Denable_float=true -Dbuilt_in_models=true'
Prevent clean targets from running in parallel to any other targets. This fixes make -j8 distclean test for example.
Use the direct paths to .venv/bin/meson and ninja as targets for the venv pip installs, rather than$(MESON) and $ (NINJA). Some of my environments are unable to build meson or ninja inside the venv, especially since we're not specifying a version. This allows you to do make NINJA=/mingw64/bin/ninja for example.
Use the ninja.build files as targets, as the mtime of the build directory is not a guarantee that the meson setup succeeded.
Upgrade pip using .venv/bin/python -m pip install --upgrade pip instead of via .venv/bin/pip, as this errors out when there is an update.