-
Notifications
You must be signed in to change notification settings - Fork 1
Clean up how we use links #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rchlfryn
wants to merge
14
commits into
main
Choose a base branch
from
link-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+316
−278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview deployment: https://link-cleanup.preview.avy-fx.org |
rchlfryn
commented
Jan 27, 2026
| admin: { | ||
| hideGutter: true, | ||
| style: { | ||
| marginBottom: '0', |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not copy this over as it is not necessary.
82800b8 to
26333bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up for we use
ButtonandCMSLinkcomponents. We currently use buttons in 3 different ways:From the linked issue:
I assume the second part of this is referring to Posthog events. All link clicks are autocaptured by posthog.
Related Issues
Resolves #685
Key Changes
ButtonLinkcomponent since we were repeating the components patterndestructiveandlinkEventTableandEventPreviewto use properButtoncomponent instead of incorrectly usedCMSLinkclearIrrelevantLinkValuestolinkFieldlinkToPageOrPosttolinkFieldlinkToPageOrPostforquickLinksconfig since the type isarrayinstead ofgroupdefaultLexicalurl validationHow to test
There should be no visual differences
Future enhancements / Questions
We could use
linkFieldinnavLink, since the configs are identical. UsinglinkFieldwill changenewTabto be the second column which will cause a migration that will create a new table and drop the old one which seems invasive for the change. Do we want to do this?