first attempt at unifying the S2 and scalar noise handling #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azrael417
reviewed
Jan 12, 2026
|
|
||
| self.noise_base_seed = 333 + comm.get_rank("data") | ||
|
|
||
| self.input_noise = GaussianVectorNoise( |
Collaborator
There was a problem hiding this comment.
I am not happy with the name. Technically that is scalar noise with respect to coords. Since we noise the channels, shall we call it feature noise instead?
| # For concatenation, we must expand explicitly if dimensions match but size doesn't | ||
| if (n.dim() == 5) and (n.shape[-2] == 1) and (n.shape[-1] == 1): | ||
| if (x.shape[-2] != 1) or (x.shape[-1] != 1): | ||
| n = n.expand(-1, -1, -1, x.shape[-2], x.shape[-1]) |
Collaborator
There was a problem hiding this comment.
Why not expand the noise tensor emitted by the layer? That could also be a base noise S2 but diagonal in H and W>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft commit to implement unified handling of perturbation modes - either through noisy S2 signals or through scalar noise vectors. Requires a rework of the preprocessor.