Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1494
This PR ensures that
Stream.legacy_default()andStream.per_thread_default()return singleton instances when called from the baseStreamclass.Previously, these methods were returning new Python instances on every call, which deviated from the intended design of exposing default streams as singletons to avoid unnecessary object creation and ensure identity consistency (e.g.,
s1 is s2). This aligns the implementation with the intended behavior discussed in #1483Changes
legacy_default()andper_thread_default()to return cachedcdefstream objects._from_handlefactory to prevent circular reference issues during Cython module initialization.LEGACY_DEFAULT_STREAMandPER_THREAD_DEFAULT_STREAMto these same singleton instances.Streamto receive unique instances of the subclass type, ensuring that specialized stream types are not forced into the base singleton.Testing