Feature/public default stream methods #1483
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
_legacy_default()and_per_thread_default()class methods public by removing the leading underscore, providing users with a clean API for accessing default streams.Changes
_legacy_default()→legacy_default()_per_thread_default()→per_thread_default()test_stream_legacy_default_public_api()andtest_stream_per_thread_default_public_api()Motivation
Previously, users had to use the undocumented workaround
Stream.from_handle(0)to access the legacy default stream. This PR provides official, documented class methods for accessing both default stream types.Testing
Note
Pre-commit's
mypy-pathfindercheck fails onload_dl_linux.py, but this is a pre-existing issue incuda_pathfinderunrelated to thesecuda_corechanges.Fixes #1445