Skip to content

Print TensorView for debugging #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wujingyue wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −10
Open

Print TensorView for debugging #5903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions csrc/host_ir/lower_to_communication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,8 @@ void lowerToBroadcast(
const DeviceMesh& sender_mesh = input_tv->getDeviceMesh();
const DeviceMesh& receiver_mesh = output_tv->getDeviceMesh();

NVF_ERROR_EQ(
sender_mesh.rank(),
1,
"Broadcast only supports a 1D sender mesh. Given ",
sender_mesh);
NVF_ERROR_EQ(
receiver_mesh.rank(),
1,
"Broadcast only supports a 1D receiver mesh. Given ",
receiver_mesh);
NVF_ERROR_EQ(sender_mesh.rank(), 1, "sender: ", input_tv->toString());
NVF_ERROR_EQ(receiver_mesh.rank(), 1, "receiver: ", output_tv->toString());
Comment on lines +151 to +152
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Error message regression: the previous message included the actual DeviceMesh ("Given ", sender_mesh/receiver_mesh). The new message prints TensorView::toString() but no longer prints the offending mesh, which can make debugging rank mismatches harder (you can’t see whether rank() is wrong because the mesh is unexpected vs the TV being different).

Consider keeping the original context and appending the TV string, e.g. include sender_mesh/receiver_mesh in the message as well.


DeviceIdxType root = sender_mesh.at(0);
Team team = receiver_mesh.vector();
Expand Down