-
Notifications
You must be signed in to change notification settings - Fork 76
debug: log propagation details #5896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review updated until commit 0ee7101 Description
|
| Relevant files | |||||||
|---|---|---|---|---|---|---|---|
| Enhancement |
| ||||||
| Cleanup |
| ||||||
| Formatting |
|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 No relevant tests |
| ⚡ Recommended focus areas for review |
Missing Testing
|
Greptile OverviewGreptile SummaryAdded debug logging infrastructure to track sharding propagation paths through the transform propagator. The changes enable developers to trace how shardings propagate between tensors during compilation. Key changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant PropagateShardingsPass
participant shardLoopLike
participant DebugLogger
participant TransformPropagator
User->>PropagateShardingsPass: Enable TransformPropagator debug option
PropagateShardingsPass->>shardLoopLike: shardLoopLike(ref, tv, parallel_types, direction)
shardLoopLike->>DebugLogger: isDebugDumpEnabled(TransformPropagator)?
alt Debug enabled
DebugLogger-->>shardLoopLike: true
shardLoopLike->>DebugLogger: debug() << ref << tv << direction << parallel_types
Note over DebugLogger: Logs: "Propagating shardings from [ref] to [tv] in [Forward/Backward] for [ParallelTypes]"
else Debug disabled
DebugLogger-->>shardLoopLike: false
end
shardLoopLike->>TransformPropagator: Continue with propagation logic
TransformPropagator-->>shardLoopLike: Propagation complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
|
!test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Summary
Testing