You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR introduces C++20 concepts but doesn't include version checks or fallback mechanisms. Ensure the codebase has proper C++20 feature detection and that this change won't break builds on older compilers that don't support concepts.
The PR removes the can_use_args_impl namespace and replaces it with concepts, but maintains compatibility variable templates. Verify that all existing code depending on the previous implementation still works correctly, especially in edge cases involving SFINAE interactions.
namespacedynamic_type {
// Concept to check if a function Fun can be called with arguments Ts...template<typenameFun, typename... Ts>conceptCanUseArgs=requires(Funf, Ts... args) {
{f(args...)};
};
// Compatibility variable template for existing codetemplate<typenameFun, typename... Ts>constexprboolcan_use_args=CanUseArgs<Fun, Ts...>;
Several complex template instantiations now use concepts instead of enable_if. The requires clauses should be thoroughly tested to ensure they properly constrain the templates in all edge cases, particularly with template template parameters and SFINAE-prone scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.